Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Jaeger] Add system tests for http thrift integration with Jaeger agent #3010

Closed
simitt opened this issue Dec 5, 2019 · 3 comments
Closed
Assignees
Milestone

Comments

@simitt
Copy link
Contributor

simitt commented Dec 5, 2019

Add system tests sending spans via a Jaeger client (http) to the APM Server.

See if we can leverage python opentelemetry-api for the tests. Be aware that it is only supported for python 3.

Part of #2886

@simitt
Copy link
Contributor Author

simitt commented Jan 7, 2020

According to Jaeger Docs#client-featuresjaeger.thrift over HTTP is not supported for Python.

An option is to start adding integration-tests in golang, using a local Elasticsearch test instance, and ensuring integration tests are only run when running system tests.

An alternative would be to record an http trift request from another library, e.g. go and then use the recorded event together with the python apache thrift implementation to send requests via the python system tests.

@axw any other suggestions are very welcome.

@axw
Copy link
Member

axw commented Jan 8, 2020

An alternative would be to record an http trift request from another library, e.g. go and then use the recorded event together with the python apache thrift implementation to send requests via the python system tests.

A simpler option would be to just send the pre-recorded data with requests, similar to what we do for the standard intake API:

requests.post(..., headers={"content-type": "application/vnd.apache.thrift.binary"})

It would be ideal to use a Jaeger client directly, but I think this reasonable would be reasonable to start with.

@simitt
Copy link
Contributor Author

simitt commented Jan 8, 2020

We can probably setup an end-to-end test including using a jaeger client to the APM Integration Testing repo, which is better suited for that any ways.

@axw axw self-assigned this Jan 8, 2020
@axw axw closed this as completed Jan 9, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants