Skip to content
This repository has been archived by the owner on Oct 28, 2024. It is now read-only.

gherkin-lint pre-commit stage does not support exclussions #694

Closed
mdelapenya opened this issue Aug 13, 2020 · 4 comments · Fixed by #723
Closed

gherkin-lint pre-commit stage does not support exclussions #694

mdelapenya opened this issue Aug 13, 2020 · 4 comments · Fixed by #723
Labels
enhancement New feature or request Team:Automation Label for the Observability productivity team

Comments

@mdelapenya
Copy link
Contributor

mdelapenya commented Aug 13, 2020

An example of how to run the lint excluding rules would be:

docker run -ti -v $(pwd):/src -w /src gherkin/lint **/*.feature --disable AvoidOutlineForSingleExample,TooClumsy,TooManySteps,TooManyDifferentTags,TooLongStep

UPDATE: yes, it's possible to use ARGS in the local hook to pass the variables

@mdelapenya mdelapenya added enhancement New feature or request Team:Automation Label for the Observability productivity team labels Aug 13, 2020
@mdelapenya
Copy link
Contributor Author

I also noticed we run one docker container per file, when it's possible to pass an expression, such as **/*.feature, and run only one container

@mdelapenya
Copy link
Contributor Author

Evaluate migrating to https://github.com/enkessler/cuke_linter, as the project we use seems abandoned (funkwerk/gherkin_lint#23)

@mdelapenya
Copy link
Contributor Author

Relates to elastic/e2e-testing#219 (comment)

@mdelapenya
Copy link
Contributor Author

The script is not using the passed-in arguments to the docker container

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request Team:Automation Label for the Observability productivity team
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant