Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrapt 1.15.0 doesn't play well with py3.12 #1894

Closed
basepi opened this issue Aug 29, 2023 · 6 comments · Fixed by #2005
Closed

Wrapt 1.15.0 doesn't play well with py3.12 #1894

basepi opened this issue Aug 29, 2023 · 6 comments · Fixed by #2005

Comments

@basepi
Copy link
Contributor

basepi commented Aug 29, 2023

Causes Django's test_stacktrace_filtered_for_elasticapm to fail.

Perhaps related to GrahamDumpleton/wrapt#231 ?

@andrei-gutierrez
Copy link

still not working with wrapt 1.15.0, I'm using 3.9.18

@timostrunk
Copy link
Contributor

In the wrapt 1.16.0 release, two important things were changed in regards to ObjectProxy:

  1. you could not set class in objectproxy: GrahamDumpleton/wrapt@fe909c2
  2. a pure python ObjectProxy alternative was exposed:
    GrahamDumpleton/wrapt@77a41f5

Currently apm-agent does not use 2.), however 2.) will definitely fix the issue here (at a performance cost).
@andrei-gutierrez Could you please retry tests with wrapt 1.16.0 as-is to see if the first change fixed this?

@xrmx
Copy link
Member

xrmx commented Mar 18, 2024

Not running all tests but with python 3.12.2 and wrapt 1.16.0 quite a bit of them pass: 876 passed, 62 skipped

@timostrunk
Copy link
Contributor

Should I send a PR to include wrapt != 1.15.* in the requirements?

@xrmx
Copy link
Member

xrmx commented Mar 18, 2024

It should be something like wrapt>=1.14.1,!=1.15.0 and install_requires in setup.cfg should be bumped too.

@timostrunk
Copy link
Contributor

I sent the PR, but the CLA process on our side will take a bit of time. I think for the moment it would be best if somebody else opened an equivalent PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants