feature: sqs queue instrumentation #2013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 20 commits
March 15, 2021 14:07
…f tests, context data
github-actions
bot
added
the
agent-nodejs
💚 Build Succeeded
Expand to view the summary
Build stats
Test stats 🧪
Trends 🧪 |
bmorelli25
reviewed
Mar 24, 2021
Co-authored-by: Trent Mick <[email protected]>
astorm
commented
Apr 1, 2021
|
jenkins run the tests please |
|
@trentm the span strategy, |
|
jenkins run the tests please |
trentm
requested changes
Apr 5, 2021
trentm
reviewed
Apr 5, 2021
|
jenkins run the tests please |
trentm
approved these changes
Apr 7, 2021
astorm
added a commit
that referenced
this pull request
Apr 8, 2021
* feat: instrument amazon SQS Adds support for Amazon SQS queues via `aws-sdk` instrumentation that partially implements the APM messaging spec https://github.com/elastic/apm/blob/master/specs/agents/tracing-instrumentation-messaging Also adds `queue.latency.min.ms`, `queue.latency.max.ms`, and `queue.latency.avg.ms` metrics for SQS queues.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #1956
This PR provides instrumentation for Amazon's SQS queues and partially implements the messaging spec.
This PR does not automatically generate transactions during message processing -- see #2012 for more information. To work around this limitation we provide documentation showing a few different ways users could use the API to generate transactions when processing messages.
We instrument the SQS method calls by wrapping the underlying AWS SDK
AWS.Request.sendmethod. The main instrumentation entry point is built in such a way that should allow us to instrument future aws-sdk services in a similar fashion.We also generate a queue latency metric using the existing measured based metric system. These new metrics are query-able via the Kibana
apmindex pattern