Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add W3C baggage support #2102

Open
trentm opened this issue Jun 8, 2021 · 3 comments
Open

add W3C baggage support #2102

trentm opened this issue Jun 8, 2021 · 3 comments
Labels
agent-nodejs Make available for APM Agents project planning.

Comments

@trentm
Copy link
Member

trentm commented Jun 8, 2021

https://w3c.github.io/baggage/

Along with 'traceparent' and 'tracestate', we could have the Node.js APM agent (and, of course, the other agents):

  1. propagate the baggage header; and
  2. provide APIs to add/get/remote baggage

At time of writing, the baggage spec is still a "First Public Working Draft (FPWD)" so priority is probably lower. One concrete possible use case (not definitive yet) is this Kibana issue -- elastic/kibana#97934 -- to attempt to propagate info on a Kibana action (front end or back end) all the way through to an Elasticsearch slowlogs entry. elastic/kibana#97934 (comment) is a description of the idea.

@pgayvallet
Copy link

Will this realistically be prioritized at any point? this is still a requierement for elastic/kibana#101708.

@trentm
Copy link
Member Author

trentm commented Jul 5, 2024

@pgayvallet It is unlikely that this will be prioritized. The focus is currently on OpenTelemetry: both the upstream github.com/open-telemetry repos and our distribution at https://github.com/elastic/elastic-otel-node/tree/main/packages/opentelemetry-node#readme, and both of which support baggage.

I think a better longer-term bet would be to consider moving Kibana's self-instrumentation to using OTel. However, granted that would be some effort.

@pgayvallet
Copy link

Yeah I agree it would make sense.

cc @lukeelmers: would it be worth opening an issue in the Kibana repo to discuss about OTel instrumentation for Kibana?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning.
Projects
None yet
Development

No branches or pull requests

2 participants