Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add serviceInstanceName config option #1322

Closed
watson opened this issue Sep 2, 2019 · 3 comments · Fixed by #1498
Closed

Add serviceInstanceName config option #1322

watson opened this issue Sep 2, 2019 · 3 comments · Fixed by #1498
Labels
enhancement low hanging fruit
Milestone
7.5

Comments

@watson
Copy link
Contributor

watson commented Sep 2, 2019

For details see elastic/apm#141
@eyalkoren eyalkoren mentioned this issue Sep 2, 2019
Closed
@curtnux
Copy link
Contributor

curtnux commented Sep 3, 2019

Hi @watson, I'm happy to pick this one up.

@watson
Copy link
Contributor Author

watson commented Sep 3, 2019

Thanks for offering to take this one @curtisjohnson1. I just checked with a colleague and we're currently waiting for elastic/kibana#43765 (comment) to be resolved before we can say for certain that we want to implement it this way. I'll update this issue once we have a resolution. Until then it's probably best to wait implementing it so you don't waste any time.

@curtnux
Copy link
Contributor

curtnux commented Sep 3, 2019

No problem, I'll leave it for now until the above issue is resolved. Thanks for getting back to me so quickly.

@lreuven lreuven added this to the 7.5 milestone Oct 3, 2019
This was referenced Nov 1, 2019
Merged
Merged
@Qard Qard closed this as completed in #1498 Nov 1, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement low hanging fruit
Projects
None yet
Milestone
7.5
Development

Successfully merging a pull request may close this issue.

feat(config): add serviceNodeName Qard/apm-agent-nodejs
3 participants
@watson @lreuven @curtnux