Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Investigate use of parent/child relationship #1239

Closed
roncohen opened this issue Jul 24, 2019 · 0 comments
Closed

Investigate use of parent/child relationship #1239

roncohen opened this issue Jul 24, 2019 · 0 comments
Labels
agent-nodejs Make available for APM Agents project planning. discuss

Comments

@roncohen
Copy link
Contributor

roncohen commented Jul 24, 2019

Today, if you have a span A that does some work, finishes and then runs it's callback to signal completion, then create a span B somewhere in the chain following the callback, the parent of B will be A. See it here: https://github.com/elastic/opbeans-node/blob/master/server/routes.js#L276-L286

We currently only support "ChildOf" and this relationship is not appropriate for this situation. If span A has finished, it should not create more "ChildOf" spans. I realize this means that for Node.js it will be increasingly rare to have any ChildOf spans that are not a ChildOf the transaction. This is OK and it's in line with what the other agents do.

Here's an example of the situation today
strange-parenting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
agent-nodejs Make available for APM Agents project planning. discuss
Projects
None yet
Development

No branches or pull requests

2 participants