Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix source jar created on Jenkins build #630

Closed
eyalkoren opened this issue May 8, 2019 · 2 comments · Fixed by #3063
Closed

Fix source jar created on Jenkins build #630

eyalkoren opened this issue May 8, 2019 · 2 comments · Fixed by #3063
Assignees
Labels
Milestone

Comments

@eyalkoren
Copy link
Contributor

After multiple tests, current situation is:
The elastic-apm-agent pom.xml has two related plugins involved with the source jar build-

  1. the maven-source-plugin is invoked at the prepare-package phase
  2. the maven-shade-plugin creates a source jar with the shaded sources

I am not entirely sure the first is required here, it is required for the attach source jar.

Invoking the exact same command as invoked by Jenkins - ./mvnw clean install -DskipTests=true -Dmaven.javadoc.skip=true creates the jar as expected. However, on Jenkins, the jar is created only with the shaded sources and without our sources (at least - this is what gets stored for the build artifacts).

@eyalkoren eyalkoren self-assigned this May 8, 2019
@alvarolobato alvarolobato modified the milestone: next May 16, 2019
@SylvainJuge SylvainJuge added the technical-debt Technical debt label Nov 13, 2019
@felixbarny
Copy link
Member

Rafael found a solution: raphw/byte-buddy#783 (comment)

@SylvainJuge SylvainJuge added bug Bugs and removed [zube]: Ready labels Feb 1, 2021
@eyalkoren
Copy link
Contributor Author

Doing some other task that required me to unarchive and look into jars reminded me this was never fixed.
The issue also affects our Javadoc jar. Both it and the sources jar only contain the co.elastic.apm.agent.premain package.
Maybe time to look into this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
6 participants