Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable ES instrumentation when a language client with included OTel instrumentation is used #3235

Closed
JonasKunz opened this issue Jul 12, 2023 · 1 comment · Fixed by #3303
Assignees
Milestone

Comments

@JonasKunz
Copy link
Contributor

elastic/elasticsearch-java#588 will bake instrumentation into the elasticsearch java client.
As soon as this PR is merged, we should make sure that our instrumentation detects versions of the client which already are instrumented and disable our instrumentation in that case.
Otherwise we might end up double recording the data.

@nithril
Copy link

nithril commented Jan 24, 2024

The issue means that when only using the APM java agent, Elasticsearch client will not be instrumented and AFAIU never be.

I'm not sure to understand the logic behind the change. The elasticsearch java client has native OTel support. But when OTel is not used why disabling ES instrumentation?

Could you please advise?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
3 participants