Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Agent can send empty transaction and span types #1211

Closed
axw opened this issue Feb 8, 2022 · 3 comments · Fixed by #1272
Closed

Agent can send empty transaction and span types #1211

axw opened this issue Feb 8, 2022 · 3 comments · Fixed by #1272
Assignees
Labels
8.5-candidate agent-go bug Something isn't working

Comments

@axw
Copy link
Member

axw commented Feb 8, 2022

Describe the bug

StartTransaction("name", "") will yield a transaction document without a transaction type field. Similar story for StartSpan("name", ""). The UI rightfully expects a non-empty transaction type and span type.

To Reproduce
Steps to reproduce the behavior:

  1. Using the agent's API, call StartTransaction("name", "").End() and StartSpan("name", "").End()
  2. Wait for ~15 seconds
  3. Check that the transaction and span are visible in the APM UI

Expected behavior

A default transaction/span type should be set, so the events are visible in the UI.

@felixbarny
Copy link
Member

The server might be a better way to fix that as it then covers all agents. But fixing it on both sides doesn't hurt, either.

@simitt
Copy link
Contributor

simitt commented Feb 22, 2022

created elastic/apm-server#7376

@simitt
Copy link
Contributor

simitt commented Jul 25, 2022

from the agent spec:

If no transaction.type or span.type is provided or the value is an empty string, the agent needs to set a default value custom.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.5-candidate agent-go bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants