Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

General support for custom DiagnosticSource #229

Closed
3 tasks
gregkalapos opened this issue May 15, 2019 · 2 comments
Closed
3 tasks

General support for custom DiagnosticSource #229

gregkalapos opened this issue May 15, 2019 · 2 comments
Labels
enhancement New feature or request TBD Issues that are up for discussion and we feel it's not even sure we want to do it.

Comments

@gregkalapos
Copy link
Contributor

From discuss.

Currently we only collect specific DiagnosticSource events. Maybe it would make sense to have a general way of collecting custom DiagnosticSource events and create spans automatically.

OpenTracing has this feature.

Scope:

  • Discuss and decide if it makes sense (probably it does I think)
  • Define high level how it works
  • Open a follow up issue to implement
@gregkalapos gregkalapos added the enhancement New feature or request label May 15, 2019
@SergeyKleyman
Copy link
Contributor

SergeyKleyman commented May 22, 2019 •
edited
Loading

As we discussed, additional points to consider:

  • How should agent set span.type and span.subtype based on data in DiagnosticSource events? (See span spec)
  • Should agent support setting parts of span.context based on data in DiagnosticSource events? For example, we can start with span.context.tags and get to more advanced use cases such as span.context.http if the need arises.

@SergeyKleyman SergeyKleyman mentioned this issue Jun 19, 2019
Closed
@gregkalapos gregkalapos added the TBD Issues that are up for discussion and we feel it's not even sure we want to do it. label Oct 15, 2019
@lreuven lreuven closed this as completed Nov 27, 2019
@lreuven
Copy link
Contributor

lreuven commented Nov 27, 2019

pushing for the future

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request TBD Issues that are up for discussion and we feel it's not even sure we want to do it.
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@gregkalapos @lreuven @SergeyKleyman