LAUNCHPAD_<browser> & LAUNCHPAD_BROWSERS env vars #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
👍 |
|
Awesome, looks good! It is missing some docs however. If you add those to the readme I can get out a 0.5.0 right away. |
|
Yeah, I was going to update the readme but somehow I didn't. :-) Anyway, the updated docs are now in place. |
|
I've added an ability to define more than one default location. Existing tests cover the changes. This is also kind of internal behavior hence no docs update. |
daffl
added a commit
that referenced
this pull request
Nov 19, 2015
LAUNCHPAD_<browser> & LAUNCHPAD_BROWSERS env vars
|
Awesome, thank you! I just published version 0.5.0. If you have another minute, an update in the changelog would also be great but the release is good to go. |
|
I've just raised another PR with changelog update: #54. Not sure if I did it correctly git-wise though. |
|
Yep that's great. Thank you again! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is related to issue #51.