-
-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merge Upstream PRs #135
Comments
Yes absolutely. I usually review every couple of weeks and I have it semi-automated to pull it in. Looks like I hadn't seen that on. I plan on jumping out of beta soon, I haven't found any new issues recently. Let me know if you do. If you want to open an issue for a candidate PR to bring it to my attention that would be great. I'll look at pulling that one over. I try and keep commit history when possible, that one looks a little messy, so I might have to do some squashing, we'll see. |
🎉 This issue has been resolved in version 3.0.0-beta.40 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Wow that was insanely fast. You are a rockstar! Thanks! |
Please give it a go and let me know if you run into any issues. I didn't have any cloud front policies to directly test it against. |
Truthfully your issue caught me at a good time, I can't promise to always be this fast, but my goal is to not let things dwindle. |
@Petersoj I actually found 2 minor issues I need to fix, PR inbound shortly. |
I will test it out soon! Thanks again. |
🎉 This issue has been resolved in version 3.0.0 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Thanks for your work on this fork and maintaining
aws-nuke
! I noticed that there are several PRs in the original project repo (like this one) that might be a good idea to merge (manually) into this fork. Any plans to do this?The text was updated successfully, but these errors were encountered: