Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Packet number recovery broken #85

Open
martinthomson opened this issue Aug 2, 2018 · 0 comments
Open

Packet number recovery broken #85

martinthomson opened this issue Aug 2, 2018 · 0 comments

Comments

@martinthomson
Copy link
Collaborator

I don't have a solid set of recommendations here, but after writing some tests, I think that the packet number recovery is broken. See this gist for some tests.

I can't really follow the logic that is there. It looks like it never rounds up, which causes it to pass the trickier underflow cases, but fail at a bunch of other tests.

I'm happy to provide an alternative implementation. The one from the spec is relatively easy to follow, or the shorter one. I thought that it might pay to discuss which is preferred before generating a PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant