Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stack warning when installing lens #731

Closed
crockeea opened this issue May 4, 2017 · 8 comments
Closed

Stack warning when installing lens #731

crockeea opened this issue May 4, 2017 · 8 comments

Comments

@crockeea
Copy link

crockeea commented May 4, 2017

When using stack to install lens, I get the following warning:

Package lens uses a custom Cabal build, but does not use a custom-setup stanza
Not using the explicit setup deps approach based on configuration
Strongly recommend fixing the package's cabal file

My stack version is Version 1.4.0, Git revision e714f1dd3fade19496d91bd6a017e435a96a6bcd (4640 commits) x86_64 hpack-0.17.0.

@ekmett
Copy link
Owner

ekmett commented May 4, 2017

This isn't currently fixable without shutting off users of older versions of cabal.

@ekmett
Copy link
Owner

ekmett commented May 4, 2017

You're going to be seeing this unfortunate warning on a lot of my packages for the next couple of years.

@phadej
Copy link
Collaborator

phadej commented May 4, 2017

In the next version there will be custom-setup stanza, with setup-depends, so it will go away (already fixed in master)

@ekmett
Copy link
Owner

ekmett commented May 4, 2017

What is the oldest version of ghc that ships with a cabal that supports custom-setup stanzas?

@phadej
Copy link
Collaborator

phadej commented May 4, 2017

@ekmett 8.0.x, yet the older Cabal don't care about custom-setup stanzas, they just issue a non-fatal warning (something like "unrecognized stanza"). The similar mechanism let us add benchmark stanzas back then; older Cabals just didn't care about it.

@ekmett
Copy link
Owner

ekmett commented May 4, 2017

Speaking of cabal-doctest. Is there an issue with it on 8.2.1?

https://travis-ci.org/ekmett/lens/jobs/227982077#L435

@phadej
Copy link
Collaborator

phadej commented May 4, 2017

@ekmett yes, I'm waiting for Cabal API to stabilize before I'll fix it. The official tag should be done soon, and there are changes not yet in hvr-ppa version of GHC (e.g. revert of rewriteFile breakage).

I'm not willing to release a cabal-doctest version supporting a version of Cabal which will be never released.

The related ticket in Cabal: haskell/cabal#3576 (comment)

@RyanGlScott
Copy link
Collaborator

As @phadej noted, you won't get this warning on a sufficiently recent Stackage resolver (e.g., nightly-2017-06-11, which I tested), since it contains a lens with a custom-setup stanza.

We've done our part here, so I'll close this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants