Skip to content

Commit

Permalink
[coq] Add "-q" to default flags.
Browse files Browse the repository at this point in the history
Fixes ocaml#3924

Actually this PR highlights a problem in the way we handle flags from
profile and from the `theory` stanza, they should form a single set I
think, however they are disjoint.

What should be done here?

Signed-off-by: Emilio Jesus Gallego Arias <[email protected]>
  • Loading branch information
ejgallego committed Nov 9, 2020
1 parent 19556d6 commit 93bf215
Show file tree
Hide file tree
Showing 2 changed files with 5 additions and 1 deletion.
2 changes: 2 additions & 0 deletions CHANGES.md
Original file line number Diff line number Diff line change
Expand Up @@ -69,6 +69,8 @@ Unreleased
- `dune describe` now also includes information about executables in addition to
that of libraries. (#3892, #3895, @nojb)

- [coq] Add `-q` flag to default `coqc` flags , fixes #3924, (# , @ejgallego)

2.7.1 (2/09/2020)
-----------------

Expand Down
4 changes: 3 additions & 1 deletion src/dune_rules/coq_rules.ml
Original file line number Diff line number Diff line change
Expand Up @@ -101,14 +101,16 @@ module Context = struct
let dir = Path.build (snd t.coqc) in
Command.run ~dir ?stdout_to (fst t.coqc) args

let standard_coq_flags = Build.return [ "-q" ]

let coq_flags t =
Build.(
map ~f:List.concat
(all
[ Expander.expand_and_eval_set t.expander t.profile_flags
~standard:(Build.return [])
; Expander.expand_and_eval_set t.expander t.buildable.flags
~standard:(Build.return [])
~standard:standard_coq_flags
]))

let theories_flags =
Expand Down

0 comments on commit 93bf215

Please sign in to comment.