Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pick: EE calculation fails if the object is too close to the corner of the pick region #940

Open
ejeschke opened this issue Apr 3, 2021 · 3 comments

Comments

@ejeschke
Copy link
Owner

ejeschke commented Apr 3, 2021

It seems that the ensquared energy calculation in Pick fails with the message:

(plot_ee) | Error making EE plot: At least one EE function must be provided

if the object is close to the edge of the pick region.

Not sure yet, but I guess this is because the cutout for EE is being done from the cutout for the pick, instead of from the full image.

@pllim
Copy link
Collaborator

pllim commented Apr 3, 2021

Yes, I only use the cutout image. Wasn't sure if I need to pass the whole image around. I figured when someone wants to measure EE, they would click on the star they want to measure anyway. 🤷

@ejeschke
Copy link
Owner Author

ejeschke commented Apr 3, 2021

@pllim, I think this is a simple fix, as I did something similar for the fwhm, IIRC. I will submit a simple PR for the fix.

@pllim
Copy link
Collaborator

pllim commented Apr 3, 2021

Sounds good to me. Thank you!

@ejeschke ejeschke mentioned this issue Jun 4, 2021
@ejeschke ejeschke mentioned this issue Feb 5, 2022
3 tasks
@ejeschke ejeschke mentioned this issue May 19, 2022
8 tasks
@ejeschke ejeschke mentioned this issue Aug 26, 2022
2 tasks
@ejeschke ejeschke mentioned this issue Jun 30, 2023
8 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants