Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTD is broken #807

Closed
pllim opened this issue Oct 31, 2019 · 7 comments
Closed

RTD is broken #807

pllim opened this issue Oct 31, 2019 · 7 comments

Comments

@pllim
Copy link
Collaborator

pllim commented Oct 31, 2019

e2b1d62 on master broke RTD:

.../ginga/ImageView.py:docstring of ginga.ImageView.ImageViewBase.get_datarect:2:
Inline literal start-string without end-string.
@ejeschke
Copy link
Owner

Sorry for the churn. I think it should be fixed now. I have to remember to python setup.py build_docs to check for documentation errors in addition to the regular tests. My bad!

@ejeschke
Copy link
Owner

ejeschke commented Nov 1, 2019

@pllim, I'm missing something on the documentation build. When I build docs locally, I get one warning about "dot" (graphviz), but otherwise the docs build is successful. On RTD, it keeps failing. It looks like it is still trying to import a method that is no longer visible. Via grep, I cannot locate any references to the method apply_transforms() in the code (it was changed to _apply_transforms() and had a method signature change).

@ejeschke
Copy link
Owner

ejeschke commented Nov 1, 2019

Is there some cache that can be cleaned out for RTD?

@pllim
Copy link
Collaborator Author

pllim commented Nov 1, 2019

Yes, you can try wiping the build and then rebuild.

@pllim
Copy link
Collaborator Author

pllim commented Nov 1, 2019

Seems fixed on master. Thanks!

@pllim pllim closed this as completed Nov 1, 2019
@ejeschke
Copy link
Owner

ejeschke commented Nov 1, 2019

Yes, you can try wiping the build and then rebuild.

@pllim, I am not 100% sure this is fixed (on RTD). How do I do the "wipe" part? PR #805 is still failing the RTD build even though it is rebased against master.

@pllim
Copy link
Collaborator Author

pllim commented Nov 1, 2019

RTD build on master seems fine today. The failure on #805 is probably real then?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants