-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Renaming throw type and exception parameter err msg to incompatible #618
base: master
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Did you look through the manual whether this needs changing somewhere?
This definitely needs a changelog entry.
Can we support both suppression keys for a transition period?
I have looked at the manual and there is no similar message key used in the manual.
Already add a changelog entry.
I have added back to old keys for this transition period. |
You left the old keys in Can we allow existing |
Addressed this comment in 7c26ec1 |
Edit: Merge after #436
I will do the two renaming first as they are the most related to our changes in #436.