Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add an option to not check dead code #627

Open
wmdietl opened this issue Nov 23, 2023 · 1 comment · May be fixed by #633
Open

Add an option to not check dead code #627

wmdietl opened this issue Nov 23, 2023 · 1 comment · May be fixed by #633

Comments

@wmdietl
Copy link
Member

wmdietl commented Nov 23, 2023

a61489c disables not checking dead code.
Up to now, the philosophy was to check all code, as it might become un-dead at some later point.
Think about adding an option to not check dead code.

There also seems to be bad interaction with the Initialization Checker. This might be related to #619 (comment); maybe for some checker the dead code detection gives the wrong results.

@wmdietl
Copy link
Member Author

wmdietl commented Nov 23, 2023

For an example why ignoring dead code is bad, see this fix: eisop-codespecs/daikon@c4f838f
The debug branch is dead code, which then leads to this true error to be missed. When debugging is enabled, that printf might crash. One would need to be careful to type-check the code again when debugging is enabled, which one might not do.

@Ao-senXiong Ao-senXiong linked a pull request Nov 25, 2023 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant