Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merging into pytest-core? #8

Closed
hpk42 opened this issue Sep 25, 2015 · 6 comments
Closed

merging into pytest-core? #8

hpk42 opened this issue Sep 25, 2015 · 6 comments

Comments

@hpk42
Copy link

hpk42 commented Sep 25, 2015

hello -- i am considering merging capturelog/catchlog functionality into core, see https://mail.python.org/pipermail/pytest-dev/2015-September/003159.html -- would be great if you participate in the discussion.

@The-Compiler
Copy link
Collaborator

We already had some discussions in #4 where we planned to move it to pytest-dev after #7 is done. #7 is the PR which improves a lot, but also changes the API in an incompatible way - I already commented there about having a compatibility layer, which I guess would be needed for merging it in.

I'm not sure if I personally would like to see it merged, actually. It'd mean I'd have to wait longer for new features compared to an independent plugin release cycle, and I have some contributions in mind 😉

@bersace
Copy link

bersace commented Jul 6, 2017

Any updates on this topic ?

@twmr
Copy link

twmr commented Jul 12, 2017

I would also be interested if this proejct were merged into pytest-core.

Now that #7 is done and the pytest-dev maintainers are in favor of the merge, we can finally start to merge it. Or shouldn't we?

@twmr
Copy link

twmr commented Sep 2, 2017

I'm not sure if I personally would like to see it merged, actually. It'd mean I'd have to wait longer for new features compared to an independent plugin release cycle, and I have some contributions in mind 😉

This is true, but we could merge it into the core but still develop it outside, like what is done for org-mode in emacs. Org-mode is merged from time to time into emacs core, but developed in a separate repository. I'm not sure if it's worth the effort, given that the current pytest release cylce is approximately one release per month.

@The-Compiler would you like a faster release cylce of pytest-dev than one release per month?

@The-Compiler
Copy link
Collaborator

No, I'm guessing that would be fine indeed.

@The-Compiler
Copy link
Collaborator

pytest-catchlog now got merged into the pytest core: pytest-dev/pytest#2794

I'll take care of some obvious remaining issues here, but I'd be glad if someone could help sorting the rest out: pytest-dev/pytest#3003

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants