Traversal operator for filtering (AIP-160)

[brk0v]

Hi team,

First of all thank you for open sourcing the support of AIPs, it's amazing work.

I have a question about the AIP-160 Filtering AIP. It seem, that you don't support the dot notation for traversal operator (a.b.c = "foo").

I'd appreciate any your suggestions where to take a look in order to add it? If it's even possible in your code structure?

Thanks and have a great day!

[zchenyu]

+1 on this!

[ericwenn]

Hello @brk0v,

Adding this should require a new Declaration and support in the parser, that's all I know for now.
If I recall correctly there were limitations in the cel-go library used that was a blocker, but that might have changed now.

[jsocol]

We've been able to make traversal work in the Checker by adding the whole path as an identifier, e.g. filtering.DeclareIdent("a.b.c", filtering.TypeString). I haven't encountered an issue in parsing. "a.b" will return a "Select" expr.Expr, e.g. if sel := exp.GetSelectExpr(); sel != nil { fmt.Println(sel.GetMember()) }

[github-actions]

This issue has been open for 365 days with no activity. Marking as stale.

[nmittler]

@ericwenn any thoughts on the solution proposed by @jsocol above?

[ericwenn]

@nmittler I don't actively work with this repository any more, so may be a bit rusty.

It sounds like that is a way forward. Are you open for trying it out?
Hopefully @odsod can help you out with a review if you take it on!

[newtonnthiga]

Hi,

Has the solution mentioned above been implemented yet?