Additional special characters in version_description causing 403 error

[Kieran-rP]

I'm getting a 403 error when deploying my application.
The problem seems to be my application version string 0.0.0-dev+440e3f0 which uses the + character to add commit hash metadata to the version number (as permitted by the semver spec)

This looks to be the same issue as #28 (and in particular @einaregilsson's fix mentioned here addresses some special characters, but not +).

Would it be possible to add + to the list of allowed (and escaped) characters?

[einaregilsson]

I just tried this and it worked for me.

Did you perhaps mean the version_label, not the version_description?

[einaregilsson]

The version label gets used for the filename in S3 and I'm not sure that allows + in it.

[einaregilsson]

This should be fixed in version 15. We now change any characters that's not alphanumeric, a dash or and underscore in the S3 filename and replace it with a dash. But the version label in Elastic Beanstalk keeps all the special characters.

[einaregilsson]

Sorry, use v16 instead, that fixes some additional issues with * in version description and truncates commit messages that are too long to be used as a version description 🙂

[Kieran-rP]

Awesome! Thanks @einaregilsson!