-
Notifications
You must be signed in to change notification settings - Fork 38
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bundle net.thisptr.jackson-jq-extra requires internal packages from net.thisptr.jackson-jq #54
Comments
I don't use OSGi and can't be of any help here. If someone can fix this issue, I'd happy to review and accept a PR to support OSGi environment. |
It's the default behavior of the maven-bundle-plugin: https://felix.apache.org/documentation/subprojects/apache-felix-maven-bundle-plugin-bnd.html#_default_behavior You can add the packages to the -instruction: |
Thanks for the suggestion. I see. Let me think a bit if we can move/rename some classes so that jackson-jq-extra (or others) doesn't have to depend on the internal package to auto-load a custom function. |
Is there any easy way to make sure this kind of issue never happens again? I was looking for an option that automatically fails a build if unexported package from other bundle is used, but maven-bundle-plugin doesn't seem to have one. |
I don't think, there is an easy way ;) |
Oh, okay... I'll merge #106 which makes jackson-jq-extra no longer depend on the internal package. Hopefully it should fix the issue :) |
The extra bundle net.thisptr.jackson-jq-extra imports the packages net.thisptr.jackson.jq.internal.misc and net.thisptr.jackson.jq.internal but they are not exported by the main bundle net.thisptr.jackson-jq. It cannot be used/installed in an OSGi environment.
The text was updated successfully, but these errors were encountered: