Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Integrate into Cargo #4

Open
UebelAndre opened this issue Nov 23, 2020 · 1 comment
Open

Integrate into Cargo #4

UebelAndre opened this issue Nov 23, 2020 · 1 comment

Comments

@UebelAndre
Copy link
Contributor

UebelAndre commented Nov 23, 2020

Just adding this here as a paper trail. I opened rust-lang/cargo#1545 which is a feature request to either integrate this crate into Cargo or for cargo to provide similar functionality. I don't expect to see any movement on this any time soon but let this issue stand as an indication that the functionality here is definitely valued.

edit: Updated issue since rust-lang/cargo#8888 is a duplicate of rust-lang/cargo#1545

@jbg
Copy link

jbg commented Apr 8, 2024

I think that if this is made built-in functionality in cargo, only the crate clone method should be included.

The other methods seem to assume that the repository key in the crate metadata points to the actual code of the crate, yet nothing guarantees that.

Especially if it's included in cargo, people may rely on this for auditing their dependencies, but the clone methods other than crate are not suitable for that purpose.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants