Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEAT] Multi domain support #25

Open
gedw99 opened this issue Aug 12, 2024 · 2 comments
Open

[FEAT] Multi domain support #25

gedw99 opened this issue Aug 12, 2024 · 2 comments
Labels
enhancement New feature or request help wanted Extra attention is needed next Smth big enough to next major version

Comments

@gedw99
Copy link

gedw99 commented Aug 12, 2024

SO that we can support multi-domains I guess we could start to detect the incoming domains used by the proxies etc using
https://github.com/pires/go-proxyproto , so that we dont need to pass ENV variables anymore.

It seems plausible that we can do this to the current _example code, and not need another example like we spoke about a few days ago.

The _example is currently working with many domains and sub domains using Caddy.
But, until proxy detection is done cant really do more there.

Will get it deploying to fly.io with the caddy stuff embedded and check multi-domain using real domains tomorrow, with hardcoded ENV, and then when proxy detection is done can try again.

@egregors let me know if you want the Makefile I used to get this working. Its just a wrapper on the current one.

@egregors
Copy link
Owner

Yep, sure! I'd like to take a look.

On one hand, I like the idea of supporting multi-domain in the _example app. On the other hand, I’d like to keep it as simple as possible so that the application doesn’t scare users away with its complexity

@gedw99
Copy link
Author

gedw99 commented Aug 14, 2024

so true. The big test of a project on GitHub is, does it work the first time after I put in 1 minutes of effort.

Let's see if https://github.com/pires/go-proxyproto works and is aligned with KISS and YAGNI principle..

@egregors egregors added enhancement New feature or request next Smth big enough to next major version labels Nov 28, 2024
@egregors egregors changed the title multi domain [FEAT] Multi domain support Nov 28, 2024
@egregors egregors added the help wanted Extra attention is needed label Nov 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed next Smth big enough to next major version
Projects
None yet
Development

No branches or pull requests

2 participants