Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sandbox css fix on tooltips #1636

Merged
merged 1 commit into from
Oct 23, 2024
Merged

Sandbox css fix on tooltips #1636

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion micro-ui/web/micro-ui-internals/packages/css/package.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
{
"name": "@egovernments/digit-ui-css",
"version": "1.8.2-beta.47",
"version": "1.8.2-beta.48",
"license": "MIT",
"main": "dist/index.css",
"author": "Jagankumar <[email protected]>",
Expand Down
4 changes: 4 additions & 0 deletions micro-ui/web/micro-ui-internals/packages/css/src/pages/employee/sandbox.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1028,3 +1028,7 @@ digit-card-text.center {
color: #363636;
line-height: 1.6;
}

.tooltiptext{
width: 30rem !important;
}
2 changes: 1 addition & 1 deletion micro-ui/web/public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@
<link
href="https://fonts.googleapis.com/css2?family=Roboto+Condensed:wght@400;500;700&family=Roboto:wght@400;500;700&display=swap"
rel="stylesheet" type="text/css" />
<link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected].47/dist/index.css" />
<link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected].48/dist/index.css" />
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🧹 Nitpick (assertive)

Consider adding a local fallback for CDN resources.

To ensure the application remains functional even if the CDN is unavailable, consider implementing a fallback mechanism.

Example implementation:

// Add this script after your stylesheet link
<script>
  function fallbackToLocalCSS(e) {
    const link = e.target;
    const localLink = document.createElement('link');
    localLink.rel = 'stylesheet';
    localLink.href = '/assets/css/digit-ui.css'; // Local fallback path
    document.head.appendChild(localLink);
  }
  document.querySelector('link[href*="digit-ui-css"]').addEventListener('error', fallbackToLocalCSS);
</script>

⚠️ Potential issue

Add integrity hash for enhanced security.

The CDN stylesheet link should include an integrity hash to prevent malicious code injection through CDN compromises.

Apply this change:

-  <link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected]/dist/index.css" />
+  <link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected]/dist/index.css" 
+        integrity_no="sha384-[HASH]" 
+        crossorigin="anonymous" />

Note: Replace [HASH] with the actual SHA-384 hash of the CSS file.

Committable suggestion was skipped due to low confidence.

💡 Codebase verification

Based on the search results, I can now provide a definitive response about the tooltip width change impact. The codebase shows that:

  1. The tooltip width is indeed set to 30rem !important in sandbox.scss
  2. The base tooltip styles in tooltip.scss show that tooltips are positioned absolutely and have responsive behavior with opacity transitions
  3. No specific media queries were found for tooltip width adjustments on smaller screens

The 30rem width (approximately 480px) could cause layout issues on mobile devices with smaller viewport widths.

Here are the specific concerns:

  • Mobile devices typically have viewport widths between 320px-480px
  • The fixed 30rem width with !important will override any responsive adjustments
  • The tooltip could overflow the screen on smaller devices
🔗 Analysis chain

Verify the tooltip width change impact.

The version update includes a .tooltiptext class with width: 30rem !important. Please ensure this change doesn't cause layout issues on smaller screens.

Let me try a different approach to search for tooltip-related code and styles.

This should help us find any tooltip-related code regardless of the file extension and also list any CSS files that might contain tooltip styles.

Based on the search results, I can see that the tooltip styles are defined in multiple files, with the main tooltip styles in micro-ui/web/micro-ui-internals/packages/css/src/pages/employee/tooltip.scss and micro-ui/web/micro-ui-internals/packages/css/src/pages/employee/sandbox.scss. Let me check the specific tooltip width implementation.

🏁 Scripts executed

The following scripts were executed for the analysis:

Script:

#!/bin/bash
# Search for tooltip-related styles and usage
echo "Searching for tooltip-related styles..."
rg -t scss "tooltip" 

echo "Searching for tooltip-related components..."
rg -t jsx -t tsx "tooltip"

Length of output: 290

Script:

#!/bin/bash
# Search for tooltip-related styles and usage without file type restrictions
echo "Searching for tooltip-related styles and components..."
rg "tooltip" -i -A 2 -B 2

# Also check if there are any CSS files directly
echo -e "\nListing CSS files in the repository..."
fd ".css$"

Length of output: 79279

Script:

#!/bin/bash
# Check the content of the tooltip style files
echo "Content of tooltip.scss:"
cat micro-ui/web/micro-ui-internals/packages/css/src/pages/employee/tooltip.scss

echo -e "\nContent of sandbox.scss:"
cat micro-ui/web/micro-ui-internals/packages/css/src/pages/employee/sandbox.scss

# Also check for any media queries related to tooltips
echo -e "\nChecking for tooltip-related media queries:"
rg "tooltip.*@media|@media.*tooltip" -A 3

Length of output: 20082

<link rel="stylesheet" href="https://unpkg.com/@egovernments/[email protected]/dist/index.css"/>
<meta name="viewport" content="width=device-width, initial-scale=1" />
<meta name="theme-color" content="#00bcd1" />
Expand Down