[sass-loader] Prepend options.data to code payload #233
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Adds `data` prepend feature common on sass-loader implementations: https://github.com/differui/rollup-plugin-sass#options-1 Care of @bastienrobert
Codecov Report
@@ Coverage Diff @@
## master #233 +/- ##
==========================================
+ Coverage 91.69% 91.72% +0.02%
==========================================
Files 9 9
Lines 289 290 +1
Branches 100 101 +1
==========================================
+ Hits 265 266 +1
Misses 24 24 Continue to review full report at Codecov.
|
himself65
requested changes
Feb 20, 2020
|
I’m going to add tests asap to merge this |
I can also write some tests today if @bastienrobert doesn't beat me to it 🤙 |
|
@drewlustro oh dude, It's actually 7PM here, I'm drinking a beer so be my guest ! 😁 |
|
✅ Tests up! cc @bastienrobert |
|
Seems good to me @drewlustro! Well done and thanks for the mention :) |
himself65
approved these changes
Mar 5, 2020
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds
dataprepend feature common on sass-loader implementations.Example: https://github.com/differui/rollup-plugin-sass#options-1
cc @cortopy @egoist