fix: add noopener noreferrer

saberland · May 28, 2019 · a06fe39 · a06fe39
1 parent 195583a
commit a06fe39
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/packages/saber-theme-portfolio/src/components/HomeProfile.vue b/packages/saber-theme-portfolio/src/components/HomeProfile.vue
@@ -24,14 +24,18 @@
       <div class="profile-meta-items">
         <div class="profile-meta-item">
           <GithubIcon />
-          <a target="_blank" :href="`https://github.com/${$themeConfig.github}`"
+          <a
+            target="_blank"
+            rel="noopener noreferrer"
+            :href="`https://github.com/${$themeConfig.github}`"
             >@{{ $themeConfig.github }}</a
           >
         </div>
         <div v-if="$themeConfig.twitter" class="profile-meta-item">
           <TwitterIcon />
           <a
             target="_blank"
+            rel="noopener noreferrer"
             :href="`https://twitter.com/${$themeConfig.twitter}`"
             >@{{ $themeConfig.twitter }}</a
           >
@@ -42,6 +46,7 @@
       </div>
       <a
         v-if="$themeConfig.sponsorLink"
+        rel="noopener noreferrer"
         target="_blank"
         class="sponsor-link"
         :href="$themeConfig.sponsorLink"

diff --git a/packages/saber-theme-portfolio/src/components/ProjectCard.vue b/packages/saber-theme-portfolio/src/components/ProjectCard.vue
@@ -1,5 +1,10 @@
 <template>
-  <a :href="project.url" class="card project" target="_blank">
+  <a
+    :href="project.url"
+    class="card project"
+    target="_blank"
+    rel="noopener noreferrer"
+  >
     <div class="project-title">{{ project.name }}</div>
     <div class="project-description">{{ project.description }}</div>
     <div class="project-meta">

diff --git a/packages/saber-theme-portfolio/src/components/SkillCard.vue b/packages/saber-theme-portfolio/src/components/SkillCard.vue
@@ -3,6 +3,7 @@
     class="card"
     :href="`https://github.com/topics/${skill.topic}`"
     target="_blank"
+    rel="noopener noreferrer"
   >
     <div
       class="skill-cover"