Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stop running command with help or version flag #64

Merged
merged 1 commit into from
Jan 27, 2020
Merged

fix: stop running command with help or version flag #64

merged 1 commit into from
Jan 27, 2020

Conversation

haoranpb
Copy link
Contributor

# cac/example
node help.js lint --help

help.js v0.0.0

Usage:
  $ help.js lint [...files]

Options:
  --type [type]  Choose a project type (default: node)
  --name <name>  Provide your name
  -h, --help     Display this message
  -v, --version  Display version number
[] { '--': [], type: 'node', h: true, help: true } <<-- command is still running

BTW, the showVersionOnExit and showHelpOnExit may also be outdated? Since they do not actually Exit anymore.

@codecov-io
Copy link

Codecov Report

Merging #64 into master will decrease coverage by 0.36%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #64      +/-   ##
==========================================
- Coverage    67.3%   66.93%   -0.37%     
==========================================
  Files           6        6              
  Lines         367      369       +2     
  Branches       91       91              
==========================================
  Hits          247      247              
- Misses        117      119       +2     
  Partials        3        3
Impacted Files Coverage Δ
src/CAC.ts 69.17% <0%> (-1.06%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7d68125...0622508. Read the comment docs.

@egoist egoist merged commit 809db10 into cacjs:master Jan 27, 2020
@egoist
Copy link
Collaborator

egoist commented Jan 27, 2020

🎉 This PR is included in version 6.5.6 🎉

The release is available on:

Your semantic-release bot 📦🚀

@haoranpb haoranpb deleted the help-version branch January 28, 2020 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants