Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

changed events module to named export. #48

Merged
merged 1 commit into from
Jun 5, 2019
Merged

changed events module to named export. #48

merged 1 commit into from
Jun 5, 2019

Conversation

mitolog
Copy link
Contributor

@mitolog mitolog commented Jun 4, 2019

This is a fix for error like:

../node_modules/cac/types/CAC.d.ts:2:8 - error TS1192: Module '"events"' has no default export.                                  

2 import EventEmitter from 'events';
         ~~~~~~~~~~~~

this may be regression on ver 6.5.1
70bc533#diff-8a596384c8f493a602203435e2130014L1

And it's same workaround as before:
c087963

@codecov-io
Copy link

Codecov Report

Merging #48 into master will not change coverage.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #48   +/-   ##
=======================================
  Coverage   59.11%   59.11%           
=======================================
  Files           6        6           
  Lines         362      362           
  Branches       91       85    -6     
=======================================
  Hits          214      214           
  Misses        145      145           
  Partials        3        3
Impacted Files Coverage Δ
src/CAC.ts 69.23% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e5f32f7...682c1d8. Read the comment docs.

@egoist egoist merged commit dae55ce into cacjs:master Jun 5, 2019
@egoist
Copy link
Collaborator

egoist commented Jun 5, 2019

🎉 This PR is included in version 6.5.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

@egoist egoist added the released label Jun 5, 2019
@mitolog
Copy link
Contributor Author

mitolog commented Jun 6, 2019

how quick merge! thanks @egoist

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants