Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: make cac work on Deno 1.16 #130

Merged
merged 1 commit into from
Nov 12, 2021
Merged

fix: make cac work on Deno 1.16 #130

merged 1 commit into from
Nov 12, 2021

Conversation

paambaati
Copy link
Contributor

See https://deno.com/blog/v1.16#improvements-to-web-streams-api

ReadableStream.getIterator has been removed. This method has been deprecated since Deno 1.7, and was never implemented in any browser. The ReadableStream itself has always implemented the AsyncIterable protocol, so use that instead when iterating over a stream.

See https://deno.com/blog/v1.16#improvements-to-web-streams-api

> `ReadableStream.getIterator` has been removed. This method has been deprecated since Deno 1.7, and was never implemented in any browser. The `ReadableStream` itself has always implemented the `AsyncIterable` protocol, so use that instead when iterating over a stream.
@codecov-commenter
Copy link

Codecov Report

Merging #130 (60815e6) into master (5e07a98) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #130   +/-   ##
=======================================
  Coverage   65.68%   65.68%           
=======================================
  Files           6        6           
  Lines         373      373           
  Branches       89       89           
=======================================
  Hits          245      245           
  Misses        126      126           
  Partials        2        2           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5e07a98...60815e6. Read the comment docs.

@egoist egoist merged commit ef52bc9 into cacjs:master Nov 12, 2021
@egoist
Copy link
Collaborator

egoist commented Nov 12, 2021

🎉 This PR is included in version 6.7.12 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants