Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add default ua egg-mock/${version} #151

Merged
merged 1 commit into from
Jan 28, 2023
Merged

fix: add default ua egg-mock/${version} #151

merged 1 commit into from
Jan 28, 2023

Conversation

killagu
Copy link
Contributor

@killagu killagu commented Jan 25, 2023

superagent not set default ua.

Checklist
  • npm test passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines
Affected core subsystem(s)
Description of change

superagent not set default ua.
@codecov
Copy link

codecov bot commented Jan 25, 2023

Codecov Report

Base: 82.88% // Head: 85.04% // Increases project coverage by +2.16% 🎉

Coverage data is based on head (14fdcf4) compared to base (9a5fcca).
Patch coverage: 87.93% of modified lines in pull request are covered.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #151      +/-   ##
==========================================
+ Coverage   82.88%   85.04%   +2.16%     
==========================================
  Files          27       27              
  Lines        2465     2515      +50     
  Branches      409      444      +35     
==========================================
+ Hits         2043     2139      +96     
+ Misses        422      376      -46     
Impacted Files Coverage Δ
lib/inject_context.js 89.79% <86.00%> (-4.09%) ⬇️
app/middleware/cluster_app_mock.js 91.46% <100.00%> (ø)
lib/mock_agent.js 100.00% <100.00%> (ø)
lib/request_call_function.js 62.50% <100.00%> (-1.50%) ⬇️
lib/supertest.js 100.00% <100.00%> (ø)
lib/app.js 97.94% <0.00%> (+1.02%) ⬆️
lib/cluster.js 95.07% <0.00%> (+2.02%) ⬆️
app/extend/application.js 95.62% <0.00%> (+9.40%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@killagu killagu requested a review from fengmk2 January 25, 2023 06:36
@fengmk2 fengmk2 merged commit ccb28f5 into master Jan 28, 2023
@fengmk2 fengmk2 deleted the fix/ua branch January 28, 2023 03:05
fengmk2 pushed a commit that referenced this pull request Jan 28, 2023
[skip ci]

## [5.10.0](v5.9.4...v5.10.0) (2023-01-28)

### Features

* add default ua egg-mock/${version} ([#151](#151)) ([ccb28f5](ccb28f5))
* impl setGetAppCallback ([#152](#152)) ([b7d902c](b7d902c))
@github-actions
Copy link

🎉 This PR is included in version 5.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants