Use closure syntax for weak and unowned vars.

[oNaiPs]

This PR uses closure syntax to define the weak/unowned variables or self, and fixes strong reference loop bugs in setLocalDescription and setRemoteDescription.
Without this fix, calling RTCPeerConnection.close() on javascript will not correctly deallocate all underlying native objects.

[ibc]

Awesome. Swift is hateful! (unowned self...).

Thanks a lot. Merged.

[ibc]

I've applied this PR and got this crash:

[ibc]

It does not crash as follows:

func RTCPeerConnection_close(command: CDVInvokedUrlCommand) {
        NSLog("iosrtcPlugin#RTCPeerConnection_close()")

        let pcId = command.argumentAtIndex(0) as! Int
        let pluginRTCPeerConnection = self.pluginRTCPeerConnections[pcId]

        if pluginRTCPeerConnection == nil {
            NSLog("iosrtcPlugin#RTCPeerConnection_close() | ERROR: pluginRTCPeerConnection with pcId=%@ does not exist", String(pcId))
            return;
        }

        dispatch_async(self.queue) {
            pluginRTCPeerConnection!.close()
        }

        // Remove the pluginRTCPeerConnection from the dictionary.
        self.pluginRTCPeerConnections[pcId] = nil
    }

I've also tried passing [weak pluginRTCPeerConnection] in to dispatch_async() but it crashes as well, so I'm worried whether the native object is not properly deallocated.

If so, would this work?

        dispatch_async(self.queue) {
            pluginRTCPeerConnection!.close()
            pluginRTCPeerConnection = nil
        }

[ibc]

I've open an issue for this at #161, let's please comment about this there.

[saghul]

I've also got the crash. Can you please revert it until it's properly
tested?
On Apr 14, 2016 07:52, "Iñaki Baz Castillo" [email protected]
wrote:

I've open an issue for this at #161
#161, let's
please comment about this there.

—
You are receiving this because you are subscribed to this thread.
Reply to this email directly or view it on GitHub
#160 (comment)

[ibc]

Please guys... let's go to #161, there are updates there, including a commit preventing the crash.