Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RTCDataChannel label cannot be empty string #124

Closed
gitlaura opened this issue Jan 28, 2016 · 1 comment
Closed

RTCDataChannel label cannot be empty string #124

gitlaura opened this issue Jan 28, 2016 · 1 comment

Comments

@gitlaura
Copy link

I'm working on an app that sometimes sets a new RTCDataChannel's label to "". I believe this is technically okay, however iosrtc throws an error here.

if (!label || typeof label !== 'string') {
  throw new Error('label argument required');
}

Can you update it so that an empty string passes? i.e.,
if ((!label && label !== "") || typeof label !== 'string')

@ibc ibc closed this as completed in 5d4aaa3 Jan 28, 2016
@ibc
Copy link
Collaborator

ibc commented Jan 28, 2016

Done.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants