Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"Could not find app javascript" when following docs on an embroider app #34

Open
gitKrystan opened this issue Feb 17, 2022 · 1 comment

Comments

@gitKrystan
Copy link

I have a brand new app using embroider for builds, and I'm trying to deploy with ember-cli-deploy-git. Following the instructions in the README, I ran into this error:

Error: Could not find app javascript: "/assets/docs.js" in index.html. Found the following instead:
 - /event-perk-grid/assets/vendor.js
 - /event-perk-grid/assets/docs.js

For more information about this error: https://github.com/thoov/stitch/wiki/Could-not-find-asset-in-entry-file-error-help

After a lot of hand-wringing, I figured out that I need a trailing slash in my rootURL.

Maybe the docs should suggest ENV.rootURL = '/your-repo-name/'; instead of ENV.rootURL = '/your-repo-name';? I'd be happy to PR it if so.

@ef4
Copy link
Owner

ef4 commented Mar 27, 2022

Thanks for this report, this is definitely an annoying problem.

A docs PR would be great, or also a PR that would automatically ensure that Embroider always interprets the rootURL as if it has a trailing slash.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants