Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue679 loader should use IoC #708

Merged
merged 19 commits into from
Dec 16, 2021
Merged

Conversation

eeverman
Copy link
Owner

@eeverman eeverman commented Dec 13, 2021

All Submissions:

Thank you! Please check that...

  • You branched from the main branch and the pull request is to the main branch
  • Your code is up to date with the latest code from main
  • You followed the guidelines in the Contributing Guide?
  • Your code does not decrease test coverage of existing code, and is near 100% for new code
  • If this is related to an issue, please include a link to the issue with the 'Fixes #XXX' syntax.

Fixes #679 (at least partially)

@codecov
Copy link

codecov bot commented Dec 13, 2021

Codecov Report

Merging #708 (b813cb9) into main (88957c7) will increase coverage by 0.36%.
The diff coverage is 96.42%.

Impacted file tree graph

@@             Coverage Diff              @@
##               main     #708      +/-   ##
============================================
+ Coverage     87.99%   88.35%   +0.36%     
- Complexity     1187     1232      +45     
============================================
  Files           133      136       +3     
  Lines          3697     3736      +39     
  Branches        442      449       +7     
============================================
+ Hits           3253     3301      +48     
+ Misses          318      313       -5     
+ Partials        126      122       -4     
Impacted Files Coverage Δ
...ndtail/andhow/load/PropFileOnFilesystemLoader.java 71.42% <ø> (ø)
...org/yarnandtail/andhow/load/std/StdJndiLoader.java 88.31% <ø> (+2.59%) ⬆️
...arnandtail/andhow/load/BaseKeyValuePairLoader.java 86.36% <86.36%> (ø)
.../yarnandtail/andhow/load/BaseFixedValueLoader.java 88.88% <88.88%> (ø)
...ava/org/yarnandtail/andhow/load/BaseMapLoader.java 95.23% <95.23%> (ø)
...c/main/java/org/yarnandtail/andhow/BaseConfig.java 87.09% <100.00%> (-1.14%) ⬇️
...rc/main/java/org/yarnandtail/andhow/StdConfig.java 87.50% <100.00%> (-3.64%) ⬇️
...nandtail/andhow/load/LoaderEnvironmentBuilder.java 100.00% <100.00%> (ø)
.../yarnandtail/andhow/load/LoaderEnvironmentImm.java 100.00% <100.00%> (ø)
...in/java/org/yarnandtail/andhow/load/MapLoader.java 100.00% <100.00%> (+6.89%) ⬆️
... and 10 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 88957c7...b813cb9. Read the comment docs.

@eeverman eeverman merged commit def7b95 into main Dec 16, 2021
@eeverman eeverman deleted the Issue679-Loader-should-use-IoC branch December 16, 2021 16:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants