Issue654 sys prop and env var loaders should trim String values #688
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r-property-testing
…r-property-testing
…r-property-testing
* Javadoc cleanup
… of github.com:eeverman/andhow into Issue676-loader-property-testing
…r-property-testing
* Some name refactoring (very internal classes - no impact) * Add tests for some untested methods * rm an unused Problem type * Nice reduction in code and increase in testing
…github.com:eeverman/andhow into Issue676-loader-property-testing
…r-property-testing
…r-property-testing
…ribute to test coverage anyway
…ys trim String values
|
This PR has pulled in the changes in the other PR (add testing) so its hard to see the changes in this one. When the other MR merges, this will be easier to see. |
Codecov Report
@@ Coverage Diff @@
## main #688 +/- ##
============================================
+ Coverage 87.31% 87.39% +0.08%
- Complexity 1165 1166 +1
============================================
Files 132 132
Lines 3730 3730
Branches 463 463
============================================
+ Hits 3257 3260 +3
+ Misses 344 340 -4
- Partials 129 130 +1
Continue to review full report at Codecov.
|
…op-and-EnvVar-loaders-should-trime # Conflicts: # andhow-testing/andhow-core-integration-test/src/test/java/org/yarnandtail/andhow/StdEnvVarLoaderIT.java # andhow-testing/andhow-core-integration-test/src/test/java/org/yarnandtail/andhow/StdSysPropLoaderIT.java # andhow-testing/andhow-core-integration-test/src/test/java/org/yarnandtail/andhow/test/bulktest/MapValueLoader.java
eeverman
changed the title
eeverman
commented
Nov 11, 2021
Comment on lines
-86
to
+91
| return false; | ||
| return true; |
There was a problem hiding this comment.
This is one of two functional changes. Everything else is javadoc updates and changes to tests.
Comment on lines
-90
to
+95
| return false; | ||
| return true; |
eeverman
deleted the
Issue654-SysProp-and-EnvVar-loaders-should-trime
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
All Submissions:
Thank you! Please check that...
Fixes #654