Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

StdSysPropLoader & StdEnvVarLoader should trim String values #654

Closed
eeverman opened this issue Oct 15, 2021 · 2 comments
Closed

StdSysPropLoader & StdEnvVarLoader should trim String values #654

eeverman opened this issue Oct 15, 2021 · 2 comments
Assignees
Milestone

Comments

@eeverman
Copy link
Owner

eeverman commented Oct 15, 2021

Describe the bug
System properties and environment vars are typically set in configuration files. Why would these not be trimmed?

This refers to these two methods:

Its likely that changing these defaults will not result in any tests breaking, but it should - tests should be added that verify the behavior.

@eeverman eeverman added this to the 0.5.0 milestone Oct 15, 2021
@eeverman eeverman changed the title StdSysPropLoader does not trim values by default StdSysPropLoader & StdEnvVarLoader do not trim values by default Oct 15, 2021
@eeverman eeverman changed the title StdSysPropLoader & StdEnvVarLoader do not trim values by default StdSysPropLoader & StdEnvVarLoader should trim String values by default Oct 26, 2021
@eeverman eeverman changed the title StdSysPropLoader & StdEnvVarLoader should trim String values by default StdSysPropLoader & StdEnvVarLoader should trim String values Oct 26, 2021
@eeverman eeverman self-assigned this Nov 11, 2021
@eeverman
Copy link
Owner Author

After changing this behavior, 31 (!) tests failed! That is good - it means the loader behavior is well tested (if not overly tested)

@eeverman
Copy link
Owner Author

Fixed by #688

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant