Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix its_key_is_value ignoring None values #401

Merged
merged 3 commits into from
Nov 2, 2020
Merged

fix its_key_is_value ignoring None values #401

merged 3 commits into from
Nov 2, 2020

Conversation

Kudbettin
Copy link
Member

@Kudbettin Kudbettin commented Oct 31, 2020 •
edited
Loading

Fixed a problem where When its property has something ignored None values.

@coveralls
Copy link

coveralls commented Oct 31, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 1307

  • 2 of 4 (50.0%) changed or added relevant lines in 1 file are covered.
  • 6 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.2%) to 56.278%
Changes Missing Coverage Covered Lines Changed/Added Lines %
terraform_compliance/steps/when/its_key_is_value.py 2 4 50.0%
Files with Coverage Reduction New Missed Lines %
terraform_compliance/common/defaults.py 6 85.0%
Totals Coverage Status
Change from base Build 1306: 0.2%
Covered Lines: 1358
Relevant Lines: 2413
💛 - Coveralls

@Kudbettin Kudbettin changed the title fix its_key_is_value ignoreing None values fix its_key_is_value ignoring None values Nov 2, 2020
@eerkunt eerkunt merged commit d254bdb into terraform-compliance:master Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Kudbettin @coveralls @eerkunt