-
Notifications
You must be signed in to change notification settings - Fork 152
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Possible bug in And its key does not include value #284
Comments
I think the issue with the first feature stems from not drilling down enough.
The problem here is that "its" still refers to aws_s3_bucket and not grant, since you haven't drilled down yet. Thus, terraform-compliance can't find permissions at all since it's looking into the wrong place. This was probably not the first thing to think about, as the error message is not relevant to the issue at all. That's going to be fixed soon. The fix could look something like this:
Here we drill down to grant, but still not fail the test if the resource does not have one. (when into then) |
Hi @Kudbettin , Thanks for your response, the above test is working as expected. |
This issue's conversation is now locked. If you want to continue this discussion please open a new issue. |
Hi @vrbcntrl, Your original features should now produce better feedback on release 1.2.5 |
Description :
A possible bug in And its key does not include value step causing the step to SKIP even when the value is found
To Reproduce
terraform
code, or yourterraform plan
file if it doesn't have any confidential information>terraform-compliance
parameters>terraform-compliance -t C:\Softwares\cloud\Terraform\0.12.24\terraform.exe -p C:\TF_Templates\plan.json -f C:\TC_Rules
Python package
4.
Expected behavior :
The Scenario should FAIL
Tested versions :
terraform-compliance -v
)>terraform-compliance v1.2.3
terraform -v
)>python --version
)>Python 3.8.2
Additional context
If I rewrite the Scenario as shown below, it is working as expected
Output:
I have also attached the plan json for your reference
plan.json.txt
The text was updated successfully, but these errors were encountered: