When I count and Then <expectation> does not work as expected

[MisterFreeze]

Description :
Using terraform-compliance version 1.0.57 and loving it!
When I count them and Then clauses for the counter do not work as expected, raising:

    Scenario: There is exactly one VPC
        Given I have any resource defined
        When its type is aws_vpc
        And I count them
        Then I expect the result is equal to 1
          AttributeError: 'Context' object has no attribute 'property_name'

To Reproduce
1.
main.tf:

resource "aws_vpc" "web_vpc" {
  cidr_block = "10.0.0.0/16" #var.web_vpc_cidr_block
  tags = merge(
    { "Name" = "vpc-testbla-13" },
    {} # var.common_tags
  )
}

2. <Used terraform-compliance parameters>
   terraform plan -out=plan.out && terraform-compliance -f test/bdd/ -p plan.out

python

    Scenario: There is exactly one VPC
        Given I have any resource defined
        When its type is aws_vpc
        And I count them
        Then I expect the result is equal to 1
          *AttributeError: 'Context' object has no attribute 'property_name'*

5. <Your feature/scenario/steps>
   (file test/bdd/webvpc.features):

Scenario: There is exactly one VPC
   Given I have any resource defined
   When its type is aws_vpc
   And I count them
   Then I expect the result is equal to 1

Expected behavior :
The scenario should pass. No exception should be raised.

Tested versions :

• 1.0.57
• 0.12.17
• 3.6.9

Additional context
The code does not reflect the test / specs that use a dict {'values': } as the code expects an integer instead of a dict.

The When I count them directive creates a {'values': <int>} dict instead of a plain int valueand assigns it to stash in [1]. Counter accesses stash and then evaluates based on the type, resulting [2] to be banced into instead of [3].

Hint:
The MockedStepContext object defines a property_name attribute that does not get assigned by default in the Given evaluation function ([4]). This lets the according test pass. ([5]).

1: https://github.com/eerkunt/terraform-compliance/blob/02be1d2c4c98754f41998ccb2e9557708eac141b/terraform_compliance/steps/steps.py#L397
2: https://github.com/eerkunt/terraform-compliance/blob/02be1d2c4c98754f41998ccb2e9557708eac141b/terraform_compliance/steps/steps.py#L423
3: https://github.com/eerkunt/terraform-compliance/blob/02be1d2c4c98754f41998ccb2e9557708eac141b/terraform_compliance/steps/steps.py#L432
4: https://github.com/eerkunt/terraform-compliance/blob/02be1d2c4c98754f41998ccb2e9557708eac141b/terraform_compliance/steps/steps.py#L44
5: https://github.com/eerkunt/terraform-compliance/blob/02be1d2c4c98754f41998ccb2e9557708eac141b/tests/mocks.py#L269

[MisterFreeze]

I figured out that a more graceful handling of property_name not being defined in fail in i_expect_the_result_is_operator_than_number ([1]) would also do it.

Not even sure if the count is meant to be used in the way I did.

1: https://github.com/eerkunt/terraform-compliance/blob/02be1d2c4c98754f41998ccb2e9557708eac141b/terraform_compliance/steps/steps.py#L414

[eerkunt]

Great to hear you loved it! 🎉

Yes, normally it requires a property to be defined, not just the resource itself, but I think this is quite a valid case. I will incorporate this into the tool! Thanks for the issue 🎉

[MisterFreeze]

Thanks @eerkunt , many thanks for the effort!
As I needed this to work, I adapted the test accordingly and tried a more graceful handling of property_name attribute not being defined. 127 tests passed. hth

[MisterFreeze]

This does not work as expected as after counting as the count function returns a dict.

Cannot count set stash to an integer or would this break any behavior?

[eerkunt]

Having a look now, sorry couldn't had a look tomorrow was quite hectic.

[eerkunt]

1.0.58 will be released in few minutes. Could you please have a try ?

[MisterFreeze]

Hi eerkunt, that works like charm! Thank you for the effort :)