Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pip install git+https://github.com/eerkunt/terraform-compliance.git does not work #143

Closed
MaT1g3R opened this issue Aug 10, 2019 · 2 comments
Closed

pip install git+https://github.com/eerkunt/terraform-compliance.git does not work #143

MaT1g3R opened this issue Aug 10, 2019 · 2 comments
Labels
bug

Comments

@MaT1g3R
Copy link
Contributor

MaT1g3R commented Aug 10, 2019

In a clean python virtualenv, pip install git+https://github.com/eerkunt/terraform-compliance.git does not work, because it tries to import from main.py before the dependencies are installed.

Moving __app_name__ and __version__ into their own file should solve this issue.

I'm happy to submit a PR for this if that's OK.
@eerkunt
Copy link
Member

eerkunt commented Aug 10, 2019

You are more than welcome to fix that :)

@eerkunt eerkunt added the bug label Aug 10, 2019
MaT1g3R added a commit to GarnerCorp/terraform-compliance that referenced this issue Aug 10, 2019
@MaT1g3R
Move app metadata into their own file
0480d9c 
- Fixes terraform-compliance#143
@MaT1g3R MaT1g3R mentioned this issue Aug 10, 2019
Merged
@eerkunt
Copy link
Member

eerkunt commented Aug 10, 2019

There was an intermittent failure while running a freshly installed terraform-compliance.

I believe this was the issue! Thanks, I couldn’t see this all those time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@eerkunt @MaT1g3R