Merge 'yaml/types' into 'yaml' & fiddle with 'yaml/util' #234
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Especially with the port to TypeScript, it makes less sense now to expose
'yaml/types'
separately from'yaml'
. So let's not.This is how you'll need to update your imports, if using:
A couple of the
'yaml/util'
exports also make more sense on'yaml'
:While we're at this, let's also add a couple of things to
'yaml/util'
that weren't exposed before:And finally, let's clear up things from the repo root that aren't needed anymore, or that we can easily hide in a
config/
directory. Leaving the Prettier & ESLint config there at least for now, because otherwise editors wouldn't find them automatically.If you're using ES modules in Node.js < 14.10, this may change how you need to import
'yaml/util'
, as the automatic named exports weren't generated for CommonJS imports until then. My suspicion is that this would affect a vanishingly small number of users, but please do let me know if it's a problem: