-
-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port several types from tap-yaml #3
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very promising! Happy to consider all of these at once. Did a first pass, but ran out of time before getting to !function
and !nullobject
. See comments inline.
0f75ceb
to
7a10202
Compare
Resolved the typos and style stuff etc that you caught, thanks for the review. |
7a10202
to
f192a08
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Finally got around to this again; sorry for the delays. Two inline comments still to resolve; I think Domains ought to get left out for now. Happy to reconsider later if another use case for them comes up.
f192a08
to
39a6182
Compare
Pulled out And actually, now that I think about it, since domains are deprecated and not really used much anymore, tap probably shouldn't give them any special treatment, and instead just remove them from the diagnostic objects anyway. |
It looks like there are a few remaining test & lint errors. Other than those, I think this is good to merge. I sent you an invite to the repo, which should let the CI tests run automatically. |
Sweet, thanks! I'll take a look this afternoon and see if I can't get the CI passing. |
39a6182
to
9b7f3cb
Compare
Test failure was because Fixed and ready to land, just waiting for CI to complete. |
9b7f3cb
to
4ad7082
Compare
@eemeli merged, but you've got the publishing keys ;) |
Done! Ended up releasing |
Happy to split this up into multiple PRs if it's easier to review separately, or send a smaller PR if only some are desired.
This is about 80% of the way to being able to just drop tap-yaml entirely in favor of yaml-types, which would be nice.