chore: add enterprise-catalog in devstack #81
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
huniafatima-arbi
force-pushed
the
huniafatima/add-enterprise-catalog-in-devstack
branch
from
5d90f7a
to
7678187
Compare
huniafatima-arbi
force-pushed
the
huniafatima/add-enterprise-catalog-in-devstack
branch
from
54705a2
to
343b4cd
Compare
docker-compose.yml
Outdated
| stdin_open: true | ||
| tty: true | ||
|
|
||
| enterprise-catalog-curations_worker: |
There was a problem hiding this comment.
Suggested change
| enterprise-catalog-curations_worker: | |
| enterprise-catalog-curations-worker: |
docker-compose.yml
Outdated
| @@ -910,3 +986,4 @@ volumes: | |||
| mysql57_data: | |||
| mysql80_data: | |||
| redis_data: | |||
| enterprise_catalog_mysql8: | |||
There was a problem hiding this comment.
This won't be used, because this isn't linked with mysql80 container. These IDAs should use default devstack db volume so no need to add this
provision-enterprise_catalog.sh
Outdated
|
|
||
| # Run migrations | ||
| echo -e "${GREEN}Running migrations for ${name}...${NC}" | ||
| docker exec -t enterprise.catalog.app bash -c "cd /edx/app/${name}/${name}/ && make migrate" |
There was a problem hiding this comment.
You should use docker compose exec and then you don't have to provide the entire container name and instead can only write enterprsie-subsidy. You can follow any other provision script for the format.
provision-enterprise_catalog.sh
Outdated
Comment on lines
18
to
20
| # Create the DOT applications - one for single sign-on and one for backend service IDA-to-IDA authentication. | ||
| docker exec -t edx.devstack.lms bash -c "source /edx/app/edxapp/edxapp_env && python /edx/app/edxapp/edx-platform/manage.py lms --settings=devstack_docker create_dot_application --grant-type authorization-code --skip-authorization --redirect-uris 'http://localhost:${port}/complete/edx-oauth2/' --client-id '${name}-sso-key' --client-secret '${name}-sso-secret' --scopes 'user_id' ${name}-sso ${name}_worker" | ||
| docker exec -t edx.devstack.lms bash -c "source /edx/app/edxapp/edxapp_env && python /edx/app/edxapp/edx-platform/manage.py lms --settings=devstack_docker create_dot_application --grant-type client-credentials --client-id '${name}-backend-service-key' --client-secret '${name}-backend-service-secret' ${name}-backend-service ${name}_worker" |
There was a problem hiding this comment.
This is also included in provision-ida-user.sh script.
provision-enterprise_catalog.sh
Outdated
|
|
||
| # Provision IDA User in LMS | ||
| echo -e "${GREEN}Provisioning ${name}_worker in LMS...${NC}" | ||
| docker exec -t edx.devstack.lms bash -c "source /edx/app/edxapp/edxapp_env && python /edx/app/edxapp/edx-platform/manage.py lms --settings=devstack_docker manage_user ${name}_worker ${name}[email protected] --staff --superuser" |
There was a problem hiding this comment.
Call provison-ida-user script here. Example: https://github.com/edx/devstack/blob/iamsobanjaved/enterprise-access/provision-insights.sh#L21
huniafatima-arbi
force-pushed
the
huniafatima/add-enterprise-catalog-in-devstack
branch
from
343b4cd
to
9105836
Compare
|
|
||
| enterprise-catalog: | ||
| volumes: | ||
| - ${DEVSTACK_WORKSPACE}/enterprise-catalog:/edx/app/enterprise_catalog/enterprise_catalog |
There was a problem hiding this comment.
Need to add devstack.py file reference as well.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.