-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add edxapp celery worker services (optional) #69
Conversation
Copied worker configs from Confluence with the following changes: - Removed newrelic integration - Added mysql80 dependency for workes (not just mysql57) - Updated image to match the newer coordinates (matching lms and cms containers, which apparently both use `lms-dev`) - Added explanation to `C_FORCE_ROOT` - Fixed cms-worker hostname (was using `lms` in name) Supporting changes: - Add docs and comment explaining how to use the workers - Add cms-worker and lms-worker to the list of services available for CLI autocomplete Some mostly unrelated cleanup as well: - Update lms and cms Django settings argument from `devstack_docker` to just `devstack`; the former only imported the latter and that has been the case for years (after the switch from Vagrant). - Alphabetize service lists (cms was renamed from studio and should have been moved) - Fix some link syntax in the service list
be41d4b
to
ba66fff
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just one minor question that's not blocking.
hostname: lms-worker.devstack.edx | ||
depends_on: | ||
- mysql80 | ||
- mysql57 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we still need both of these? I'm assuming you included them because it's already how lms and cms already do them.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No idea! Just copying what's done in lms and cms, like you say. I assume someone will come through and do cleanup at some point and I figured it would be best to leave it as close to the other instances as possible.
@timmc-edx , this PR introduces an issue running
|
Oops, I see I missed a spot. PR to fix: #70 Interestingly, I don't get that symptom... maybe some difference between Mac and Linux docker. But this should fix it either way. |
@nsprenkle Merged -- let me know if that fixes it for you. |
@timmc-edx, yes that seems to work for me :) |
Copied worker configs from Confluence with the following changes:
lms-dev
)C_FORCE_ROOT
lms
in name)Supporting changes:
Some mostly unrelated cleanup as well:
devstack_docker
to justdevstack
; the former only imported the latter and that has been the case for years (after the switch from Vagrant).I've completed each of the following or determined they are not applicable: