Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RFC: Add mathematical/arrows unicode operator support #283

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
34 changes: 21 additions & 13 deletions src/Idris/Parser.idr
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,15 @@ export
plhs : ParseOpts
plhs = MkParseOpts False False

leftArrow : Rule ()
leftArrow = symbol "<-" <|> symbol "←"

rightArrow : Rule ()
rightArrow = symbol "->" <|> symbol "→"

doubleRightArrow : Rule ()
doubleRightArrow = symbol "=>" <|> symbol "⇒"

atom : FileName -> Rule PTerm
atom fname
= do start <- location
Expand Down Expand Up @@ -436,12 +445,11 @@ mutual

bindSymbol : Rule (PiInfo PTerm)
bindSymbol
= do symbol "->"
= do rightArrow
pure Explicit
<|> do symbol "=>"
<|> do doubleRightArrow
pure AutoImplicit


explicitPi : FileName -> IndentInfo -> Rule PTerm
explicitPi fname indents
= do start <- location
Expand All @@ -461,7 +469,7 @@ mutual
commit
binders <- pibindList fname start indents
symbol "}"
symbol "->"
rightArrow
scope <- typeExpr pdef fname indents
end <- location
pure (pibindAll (MkFC fname start end) AutoImplicit binders scope)
Expand All @@ -475,7 +483,7 @@ mutual
t <- simpleExpr fname indents
binders <- pibindList fname start indents
symbol "}"
symbol "->"
rightArrow
scope <- typeExpr pdef fname indents
end <- location
pure (pibindAll (MkFC fname start end) (DefImplicit t) binders scope)
Expand All @@ -501,7 +509,7 @@ mutual
symbol "{"
binders <- pibindList fname start indents
symbol "}"
symbol "->"
rightArrow
scope <- typeExpr pdef fname indents
end <- location
pure (pibindAll (MkFC fname start end) Implicit binders scope)
Expand All @@ -511,7 +519,7 @@ mutual
= do start <- location
symbol "\\"
binders <- bindList fname start indents
symbol "=>"
doubleRightArrow
mustContinue indents Nothing
scope <- expr pdef fname indents
end <- location
Expand Down Expand Up @@ -614,7 +622,7 @@ mutual

caseRHS : FileName -> FilePos -> IndentInfo -> PTerm -> Rule PClause
caseRHS fname start indents lhs
= do symbol "=>"
= do doubleRightArrow
mustContinue indents Nothing
rhs <- expr pdef fname indents
atEnd indents
Expand Down Expand Up @@ -703,7 +711,7 @@ mutual
-- If the name doesn't begin with a lower case letter, we should
-- treat this as a pattern, so fail
validPatternVar n
symbol "<-"
leftArrow
val <- expr pdef fname indents
atEnd indents
end <- location
Expand All @@ -729,7 +737,7 @@ mutual
(do atEnd indents
end <- location
pure [DoExp (MkFC fname start end) e])
<|> (do symbol "<-"
<|> (do leftArrow
val <- expr pnowith fname indents
alts <- block (patAlt fname)
atEnd indents
Expand Down Expand Up @@ -1196,15 +1204,15 @@ getRight (Right v) = Just v
constraints : FileName -> IndentInfo -> EmptyRule (List (Maybe Name, PTerm))
constraints fname indents
= do tm <- appExpr pdef fname indents
symbol "=>"
doubleRightArrow
more <- constraints fname indents
pure ((Nothing, tm) :: more)
<|> do symbol "("
n <- name
symbol ":"
tm <- expr pdef fname indents
symbol ")"
symbol "=>"
doubleRightArrow
more <- constraints fname indents
pure ((Just n, tm) :: more)
<|> pure []
Expand All @@ -1218,7 +1226,7 @@ implBinds fname indents
symbol ":"
tm <- expr pdef fname indents
symbol "}"
symbol "->"
rightArrow
more <- implBinds fname indents
pure ((n, rig, tm) :: more)
<|> pure []
Expand Down
66 changes: 42 additions & 24 deletions src/Parser/Lexer.idr
Original file line number Diff line number Diff line change
Expand Up @@ -107,21 +107,54 @@ blockComment = is '{' <+> is '-' <+> toEndComment 1
docComment : Lexer
docComment = is '|' <+> is '|' <+> is '|' <+> many (isNot '\n')

--
-- Symbols
--

export
isOpChar : Char -> Bool
isOpChar c = inLatin || inArrows || inMathematicalOperators
where
inRange : (Int, Int) -> Lazy Bool
inRange (lowerBound, upperBound) = (c >= chr lowerBound && c <= chr upperBound)
inLatin = c `elem` (unpack ":!#$%&*+./<=>?@\\^|-~")
inArrows = inRange (8592, 8703)
inMathematicalOperators = inRange (8704, 8959)

nonOpCharUnicode : Char -> Bool
nonOpCharUnicode c = (c > chr 160) && not (isOpChar c)


validSymbol : Lexer
validSymbol = some (pred isOpChar)

||| Special symbols - things which can't be a prefix of another symbol, and
||| don't match 'validSymbol'
export
symbols : List String
symbols
= [".(", -- for things such as Foo.Bar.(+)
"@{",
"[|", "|]",
"(", ")", "{", "}", "[", "]", ",", ";", "_",
"`(", "`"]

--
-- Identifier Lexer
-- There are multiple variants.

data Flavour = Capitalised | AllowDashes | Normal

isIdentStart : Flavour -> Char -> Bool
isIdentStart _ '_' = True
isIdentStart Capitalised x = isUpper x || x > chr 160
isIdentStart _ x = isAlpha x || x > chr 160
isIdentStart Capitalised c = isUpper c || nonOpCharUnicode c
isIdentStart _ c = isAlpha c || nonOpCharUnicode c

isIdentTrailing : Flavour -> Char -> Bool
isIdentTrailing AllowDashes '-' = True
isIdentTrailing _ '\'' = True
isIdentTrailing _ '_' = True
isIdentTrailing _ x = isAlphaNum x || x > chr 160
isIdentTrailing _ c = isAlphaNum c || nonOpCharUnicode c

%inline
isIdent : Flavour -> String -> Bool
Expand Down Expand Up @@ -160,6 +193,10 @@ recField = is '.' <+> ident Normal
pragma : Lexer
pragma = is '%' <+> ident Normal

--
-- Literal Lexers
--

doubleLit : Lexer
doubleLit
= digits <+> is '.' <+> digits <+> opt
Expand Down Expand Up @@ -194,32 +231,13 @@ keywords = ["data", "module", "where", "let", "in", "do", "record",
special : List String
special = ["%lam", "%pi", "%imppi", "%let"]

-- Special symbols - things which can't be a prefix of another symbol, and
-- don't match 'validSymbol'
export
symbols : List String
symbols
= [".(", -- for things such as Foo.Bar.(+)
"@{",
"[|", "|]",
"(", ")", "{", "}", "[", "]", ",", ";", "_",
"`(", "`"]


export
isOpChar : Char -> Bool
isOpChar c = c `elem` (unpack ":!#$%&*+./<=>?@\\^|-~")

validSymbol : Lexer
validSymbol = some (pred isOpChar)

-- Valid symbols which have a special meaning so can't be operators
export
reservedSymbols : List String
reservedSymbols
= symbols ++
["%", "\\", ":", "=", "|", "|||", "<-", "->", "=>", "?", "!",
"&", "**", ".."]
["%", "\\", ":", "=", "|", "|||", "?", "!", "&", "**",
"..", "<-", "->", "=>", "←", "→", "⇒"]

fromHexLit : String -> Integer
fromHexLit str
Expand Down
2 changes: 2 additions & 0 deletions tests/Main.idr
Original file line number Diff line number Diff line change
Expand Up @@ -51,6 +51,8 @@ idrisTests
"literate001", "literate002", "literate003", "literate004",
"literate005", "literate006", "literate007", "literate008",
"literate009", "literate010", "literate011", "literate012",
-- Unicode
"unicode001",
-- Interfaces
"interface001", "interface002", "interface003", "interface004",
"interface005", "interface006", "interface007", "interface008",
Expand Down
9 changes: 9 additions & 0 deletions tests/idris2/unicode001/Unicode.idr
Original file line number Diff line number Diff line change
@@ -0,0 +1,9 @@
module Unicode

infix 6 ≡, ≢

public export
interface UnicodeEq a where
(≡) : a → a → Bool
(≢) : a → a → Bool

1 change: 1 addition & 0 deletions tests/idris2/unicode001/expected
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
1/1: Building Unicode (Unicode.idr)
3 changes: 3 additions & 0 deletions tests/idris2/unicode001/run
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
$1 -c Unicode.idr

rm -rf build/