NM + Network: Cleanup network state updates #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Jun 16, 2022
jwijenbergh
force-pushed
the
cleanup-signals
branch
from
fc32759 to
646052f
Compare
- Use the pygobject signals to properly check whether we have the correct UUID - Delete polling every second as that is hopefully not useful any more - Delete unknown state retry mechanism for the same reason - Should fix eduvpn#464 and hopefully eduvpn#492
- Using the primary connection is not fool proof
jwijenbergh
force-pushed
the
cleanup-signals
branch
2 times, most recently
from
ced90d3 to
247cd00
Compare
This fixes a major bug where OpenVPN doesn't work on a reconnect. This bug is not introduced by this PR, it's already present on master. The problem was that we only got a new connect configuration in the case of WireGuard, which is not right. We should always get a new connect configuration as '/disconnect' is called.
jwijenbergh
force-pushed
the
cleanup-signals
branch
from
247cd00 to
5072ab1
Compare
|
Tested on Ubuntu 18.04, Arch, Fedora & my own OS (NixOS). Works fine. Also I can confirm myself that this closes #464 |
gijzelaerr
approved these changes
Jun 22, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
correct UUID
Needs some testing to determine if this works on most vms and configurations. But for me this works MUCH better, especially when you have multiple VPNs configured