Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

up readerSettings Preset tab UI + translation #2610

Merged
merged 5 commits into from
Oct 21, 2024
Merged

up readerSettings Preset tab UI + translation #2610

merged 5 commits into from
Oct 21, 2024

Conversation

arthur-lemeur
Copy link
Collaborator

No description provided.

panaC
panaC requested changes Oct 15, 2024
View reviewed changes
Copy link
Member

@panaC panaC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Capture d’écran du 2024-10-15 14-27-27
Capture d’écran du 2024-10-15 14-27-51

reset buttons not aligned

Also I notice that when I click on the button the blue focus is not released, I don't know if my click is captured or not, no blue outline change.

@panaC panaC marked this pull request as draft October 15, 2024 12:30
@panaC panaC marked this pull request as ready for review October 21, 2024 13:34
@panaC panaC merged commit 6c4b08a into develop Oct 21, 2024
7 checks passed
@panaC panaC deleted the dev/readerSettingsPreset-UI branch October 21, 2024 13:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@panaC panaC panaC requested changes

Assignees

@arthur-lemeur arthur-lemeur

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arthur-lemeur @panaC